Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

209 include new generative plugin great #214

Merged
merged 9 commits into from
Aug 10, 2023

Conversation

robsdavis
Copy link
Contributor

Description

This PR adds a new Plugin, GReaT. It is a lightweight wrapper around the library be_great.
This library has dependency conflicts with arfpy and so, this PR moves the arf plugin to an extra and implements this new plugin as an extra. These extras are not included in the all extra, so that the user can install with:

pip install .[all]
pip install .[arf]

or

pip install .[all]
pip install .[great]

depending on preference for one plugin or the other.

Affected Dependencies

Additional dependency: be_great.

How has this been tested?

  • tests for the plugin are in "synthcity/tests/plugins/generic/test_great.py" and are analogous to other plugins such as goggle
  • A tutorial is provided in "/home/rob/Documents/projects/synthcity/tutorials/plugins/generic/plugin_great.ipynb", which is tested by the nb_eval.py test when the all_tests option is applied.

Checklist

@robsdavis robsdavis linked an issue Aug 9, 2023 that may be closed by this pull request
@robsdavis robsdavis added the enhancement New feature or request label Aug 9, 2023
@robsdavis robsdavis merged commit e5580a3 into main Aug 10, 2023
@robsdavis robsdavis deleted the 209-include-new-generative-plugin-great branch August 10, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include new generative plugin: GREAT
1 participant