Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows plugins that have been added by the user at runtime to be stored in the Plugins() context. The most important benefit of which is that it makes these user added plugins available to
Benchmarks.evaluate()
. This is achieved by the addition of two dictionary objects:"PLUGIN_REGISTRY"
and"PLUGIN_CATEGORY_REGISTRY"
toplugin.py
. These dictionaries store all the plugins that get added by thePluginLoader
. A newPluginLoader._refresh()
function sets the values of these new dictionaries toself._plugins
andself._categories
._refresh
is called by all the functions that access the_plugins
of_categories
attributes, meaning that added plugins are always available.closes #225
Affected Dependencies
None
How has this been tested?
synthcity.plugins.Plugins().list()
Benchmarks.evaluate()
Checklist