feat: Add custom User-Agent header to Flight SQL JDBC driver #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a custom User-Agent header to the Arrow Flight SQL JDBC driver to provide client information to the server. The implementation: - Creates a new UserAgentUtils class to generate a standardized User-Agent string - Includes driver version, OS information, Java version, and client application name - Uses a custom header name "x-arrow-user-agent" to avoid conflicts with HTTP/2 reserved headers - Caches the driver version to improve performance - Adds unit tests to verify the functionality The User-Agent string follows the format: "ArrowFlightJDBC/<version> (<OS>; <Java version>; <client app>)" This allows servers to track client versions and implement version-specific workarounds if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for custom User-Agent headers in the Flight SQL JDBC driver.
Changes
Purpose
This enhancement allows applications using the Flight SQL JDBC driver to:
Testing
Notes
This PR is created on my personal fork for colleague review before potential submission to the upstream Apache Arrow repository.
Ready for Review 🔍
Please review the changes and provide feedback. Once approved here, we can consider submitting this to the upstream Apache Arrow project.
Pull Request opened by Augment Code with guidance from the PR author