Adding better code coverage.

gogogate2_api/common.py

@@ -27,12 +27,7 @@ class TagException(Exception):
 
     def __init__(self, tag: str, message: str) -> None:
         super().__init__(message)
-        self._tag: Final = tag
-
-    @property
-    def tag(self) -> str:
-        """Get the tag."""
-        return self._tag
+        self.tag: Final = tag
 
 
 class TagNotFoundException(TagException):
@@ -59,18 +54,8 @@ def __init__(self, value: Any, expected: Type[GenericType]):
         super().__init__(
             'Expected of "%s" to be "%s" but was "%s."' % (value, expected, type(value))
         )
-        self._value: Final = value
-        self._expected: Final = expected
-
-    @property
-    def value(self) -> Any:
-        """Get value."""
-        return self._value
-
-    @property
-    def expected(self) -> Type[GenericType]:
-        """Get expected type."""
-        return self._expected
+        self.value: Final = value
+        self.expected: Final = expected
 
 
 def enforce_type(value: Any, expected: Type[GenericType]) -> GenericType:

tests/test_common.py

@@ -16,6 +16,7 @@
     get_configured_doors,
     int_or_raise,
     str_or_raise,
+    get_configured_door_by_id,
 )
 import pytest
 from typing_extensions import Final
@@ -64,7 +65,7 @@ def test_enum_or_raise() -> None:
         assert exinfo.value.expected == DoorStatus
 
 
-def test_get_enabled_doors() -> None:
+def test_get_configured_doors() -> None:
     """Test get configurd doors."""
     response: Final = GogoGate2InfoResponse(
         user="user1",
@@ -122,4 +123,7 @@ def test_get_enabled_doors() -> None:
         wifi=Wifi(SSID="", linkquality="", signal=""),
     )
 
+    assert get_configured_door_by_id(1, response) == response.door1
+    assert not get_configured_door_by_id(2, response)
+    assert get_configured_door_by_id(3, response) == response.door3
     assert get_configured_doors(response) == (response.door1, response.door3)