research/fragattack: implement --pre-test-delay #44
Conversation
research/fraginternals.py
Outdated
| @@ -996,6 +996,7 @@ def handle_eth_dhcp(self, p, station): | |||
| if req_type != 3: return | |||
|
|
|||
| peerip = self.dhcp.leases[station.get_peermac()] | |||
| time.sleep(self.options.connected_delay) | |||
| log(STATUS, f"Client {station.get_peermac()} with IP {peerip} has connected") | |||
| station.set_ip_addresses(self.arp_sender_ip, peerip) | |||
|
|
|||
There was a problem hiding this comment.
@angeloc There are few problems here:
- Suggested-by is missing
- The sleep should happen happen after the print
- Suggest even to move after set_ip_address
|
The delay was implemented in This delay should happen after completing the 4-way handshake. The delay that you seem to be adding is done after getting an IP address. I suppose this difference was important in your case. Can you confirm that a delay after getting the IP address was important? We can add a separate parameter for that. |
|
Correct, if we don't have the delay the ping packet in receive interface is dropped. We will check it |
angeloc
force-pushed
the
connected_delay
branch
from
b45cf53
to
5af94ca
Compare
angeloc
changed the title
angeloc
force-pushed
the
connected_delay
branch
from
5af94ca
to
eb436e0
Compare
|
Thanks for the update, will try to find time to check this. |
pre_delay can be used to add a delay before actually executing the test. Suggested-by: Michael Trimarchi <michael@amarulasolutions.com> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Adding a delay before actually executing the test. This can be useful in all the cases the network stack of the victim is still not ready to receive packets leading to a timed out test result. Suggested-by: Michael Trimarchi <michael@amarulasolutions.com> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
This parameter can be used each time a test needs to be delayed before actually executing it. Suggested-by: Michael Trimarchi <michael@amarulasolutions.com> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
vanhoefm
force-pushed
the
connected_delay
branch
from
eb436e0
to
0375781
Compare
|
Looks good. I've tweaked the code and pushed those changes (it's the first time I edited a pull request so hopefully that went well). If possible, can you confirm that the updated code works for you? Then I'll merge these changes. |
|
Looks good to me! |
Adding --pre-test-delay parameter