Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly resolve module paths when using Vite plugins that affect module resolution #1309

Merged
merged 14 commits into from
Feb 4, 2024

Conversation

mrm007
Copy link
Contributor

@mrm007 mrm007 commented Feb 3, 2024

Fixes #1302.

The vite-node compiler now uses absolute paths internally, to avoid situations where a compilerOptions.baseUrl is defined and we incorrectly make paths root relative.

Other changes:

I had to upgrade the monorepo to TypeScript v5, but that doesn't have any effect on anything.

I moved tests from Vitest to Jest. Vitest has trouble correctly identifying and updating inline snapshots, but Jest handles them fine.

Probably easier to review some changes commit-by-commit.

Copy link

changeset-bot bot commented Feb 3, 2024

🦋 Changeset detected

Latest commit: 02db386

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@vanilla-extract/integration Major
@vanilla-extract/vite-plugin Patch
@vanilla-extract/esbuild-plugin-next Patch
@vanilla-extract/esbuild-plugin Patch
@vanilla-extract/jest-transform Patch
@vanilla-extract/parcel-transformer Patch
@vanilla-extract/rollup-plugin Patch
@vanilla-extract/webpack-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👏

Just some minor comments.

tests/compiler/fixtures/tsconfig-paths/src/main.tsx Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.changeset/integration.md Show resolved Hide resolved
tests/compiler/compiler.vitest.test.ts Show resolved Hide resolved
@mrm007 mrm007 force-pushed the 1302-no-css-for-file branch from 2422470 to 02db386 Compare February 4, 2024 02:57
@mrm007 mrm007 merged commit fdafb6d into master Feb 4, 2024
12 checks passed
@mrm007 mrm007 deleted the 1302-no-css-for-file branch February 4, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 'No CSS for file' with vite and tsconfig-paths
2 participants