vite: Create compiler during buildStart instead of configResolved

[himself65]

Related: dai-shi/waku#559

[changeset-bot]

🦋 Changeset detected

Latest commit: d9d4f9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@vanilla-extract/vite-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[askoufis]

@himself65 Thanks for the PR. Could you provide some more context on what the issue is and how this change fixes it?

I can sort of see how createCompiler is better placed in the buildStart() hook, but I don't think the !compiler check is achieving anything here. Were you observing the compiler being recreated, leading to a bug?

[himself65]

@himself65 Thanks for the PR. Could you provide some more context on what the issue is and how this change fixes it?

I can sort of see how createCompiler is better placed in the buildStart() hook, but I don't think the !compiler check is achieving anything here. Were you observing the compiler being recreated, leading to a bug?

Yeah, the issue is when we call resolveConfig in node.js, buildEnd won't be called in this case, so that the node.js process cannot exit successfully

[himself65]

!compiler check

Oh, that is my mistake

[askoufis]

@himself65 Thanks for the PR. Could you provide some more context on what the issue is and how this change fixes it?
I can sort of see how createCompiler is better placed in the buildStart() hook, but I don't think the !compiler check is achieving anything here. Were you observing the compiler being recreated, leading to a bug?

Yeah, the issue is when we call resolveConfig in node.js, buildEnd won't be called in this case, so that the node.js process cannot exit successfully

Oh I understand now. So resolveConfig calls the configResolved hooks of plugins, so a compiler is created but never destroyed. Makes sense to me. I'll add a changeset.

[askoufis]

@himself65 This has been released https://github.com/vanilla-extract-css/vanilla-extract/releases/tag/%40vanilla-extract/vite-plugin%404.0.5