Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: Remove lodash dependency #1388

Merged
merged 2 commits into from
Apr 29, 2024
Merged

integration: Remove lodash dependency #1388

merged 2 commits into from
Apr 29, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Apr 20, 2024

Not a huge fan of using lodash for a single function, especially since it tends to not get tree-shaken very well (though I suppose that depends on how smart your bundler is).

Copied the isPlainObject implementation from here.

Copy link

changeset-bot bot commented Apr 20, 2024

🦋 Changeset detected

Latest commit: aa18325

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vanilla-extract/integration Patch
@vanilla-extract-private/tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis changed the title Remove lodash dependency integration: Remove lodash dependency Apr 20, 2024
@askoufis askoufis enabled auto-merge (squash) April 29, 2024 12:44
@askoufis askoufis merged commit 6066606 into master Apr 29, 2024
11 checks passed
@askoufis askoufis deleted the remove-lodash branch April 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants