Update vite and vite-node, support Vite 6, drop support for Vite 4
#1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 166e8ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Oh man, I can't wait for this. I'm moving from Next to Astro and this is the only thing blocking me. |
…ct into update-vite
…ct into update-vite
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1509. Resolves #1520. Closes #1508 (superseded by this PR).
Changes
vite,vite-node,vitestandvite-tsconfig-pathshave all been updated.vite-node@3dropped support for for Vite 4, so we have done the same.vite-tsconfig-pathsis now ESM-only so needs to be dynamically imported (even though we're running ESM jest tests).I've implemented a workaround for vitejs/vite#19245 in the compiler. This only necessary to fix a bug when running the compiler inside
jest, which is probably only relevant for the tests in this repo. I doubt there are many vite (and hence compiler) consumers not usingvitest, let alone actually testing the compiler. The workaround should have no effect on the compiler's functionality.EDIT: Looks like my fix for the bug will be released in vite 6.1.0. Will keep the workaround code around until that's released.
The update to the rollup plugin snapshot was likely a result of updating some
rollup-related deps as part of the lockfile dedupe commit 0325c1c.