fix: normalize path(vitejs/vite#4556)

[ygj6]

Fixes vitejs/vite#4556

See issue comment for details

[changeset-bot]

🦋 Changeset detected

Latest commit: e733e23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@vanilla-extract/vite-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mattcompiles]

Thanks for the PR. Just need you to remove your package.json change.

[mattcompiles]

Not sure why this was changed? Can you please revert this?

[ygj6]

https://github.com/seek-oss/vanilla-extract/blob/7c396ea58f5af60e65176875ae9c93764fe77fd2/packages/vite-plugin/src/index.ts#L2

Since we need to import the normalizePath method and use it, we need to adjust the vite dependencies to dependencies or peerDependencies, otherwise an exception will occur at build.

Maybe I should have adjusted it to peerDependencies more appropriately.

[mattcompiles]

Right. Sorry I misread this change. I think peerDependencies is the right call here.

[ygj6]

Done, thank you for the review.

[mattcompiles]

Sorry but you'll need to leave the dev dependency there as well, otherwise it may not be accessible locally.

[ygj6]

Sorry, I don't quite understand what you mean, because it is a plugin for vite, there is no way to run it alone, it can only work with vite, so vitemust exist.

[ygj6]

I noticed that the check failed and it says I can't modify the dependency, what should I do?

[mattcompiles]

@ygj6 Hey Bud. This looks good but it's failing the format check. I tried to push the change to your branch but you haven't given me permission. Running yarn format and pushing the result should be enough to get CI green and then we can merge 👍

[ygj6]

@ygj6 Hey Bud. This looks good but it's failing the format check. I tried to push the change to your branch but you haven't given me permission. Running yarn format and pushing the result should be enough to get CI green and then we can merge 👍

An invitation has been extended and you need to agree.

[ygj6]

Done, thanks for your patience in reviewing, I've done yarn formatting of the code.
Also, there were too many commits records and I did a rebase.

[mattcompiles]

Thanks for the fix mate 👍