-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vite: Add experimental support for Astro #796
Conversation
🦋 Changeset detectedLatest commit: b15c813 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I just updated and tested (with your pr) the reproduction to make the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Changes makes sense. Just a few comments around keeping the plugin as simple as possible.
Co-authored-by: mattcompiles <mattjones701@gmail.com>
Thanks for review. I have updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this as a code change.
@mechairoi Is it worth adding some docs for Astro users? Is it understood that Vite plugins generally work in Astro builds?
@mattcompiles I think it is better to add some docs. The reference is almost all the description of the Vite plugins in the Astro docs. |
@mechairoi I'll merge this for now. If you want to contribute some Astro specific docs then feel free to open another PR 😄 |
Generate CSS when in the Astro build and SSR flag is enabled, similar to the React Server Component (#751).
Will fix #795
The reproduction of #795 seems to work correctly both of
dev
andbuild
. (The build needs to movepages/index.css.ts
outside ofpages/
so that it is not treated as an entry point.)