-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vite-plugin: Whitelist vite-plugin-svelte
#952
Conversation
…SsrBuild` configurable.
🦋 Changeset detectedLatest commit: 73b8f17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FWIW I also added an option for |
Nice, I do disagree with you about "would probably allow removing the hard-coded checks", the point of these is to reduce friction in cases where it's definitely required. This is good DX. Let's home something gets merged soon. |
ah yes you're right, it makes sense for the DX ! |
What does this need to be merged? |
@michaeltaranto @mattcompiles @markdalgleish What needs to be done here? This fixes VE usage for SvelteKit and probably others. VE is practically unusable on non-whitelisted frameworks right now as SSR FOUC is a problem. |
We will look at adding this flag along with documentation in a separate PR.
vite-plugin-svelte
and make forceEmitCssiInSsrBuild
configurable.vite-plugin-svelte
Discussed this one at the maintainers meeting this morning and we are going to split this into two so we can get sveltekit out the door. We will look at adding the forceSSR flag in a separate PR along with documentation. |
vite-plugin-svelte
.Resolves #937
I'm not sure how this plays into #851, that PR seems dead/invalid?
This fixes SSR support in sveltekit, at least, and provides an override for other framework users to use before built-in support is added.