Feat/custom separator #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 18, 2023 13:05
one character
support to stringify function
evanplaice
force-pushed
the
main
branch
3 times, most recently
from
51108d9 to
c1b4e98
Compare
|
|
||
| array.forEach((row, rIdx) => { | ||
| let entry = '' | ||
| ctx.col = 1 | ||
| row.forEach((col, cIdx) => { | ||
| if (typeof col === 'string') { | ||
| col = col.replace(/"/g, '""') | ||
| col = needsDelimiters.test(col) ? `"${col}"` : col | ||
| col = col.replace(ctx.options.delimiter, `${ctx.options.delimiter}${ctx.options.delimiter}`) |
There was a problem hiding this comment.
This only replace the first instance of the delimiter in a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for issue #21 - Feature request for custom separator and delimiter
index.js
parse()
stringify()
options.spec.js
extended test suite by eight new tests to ensure the correct usage of the separator and delimiter option