Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java classes being skipped in AGP >= 3.4 #166

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

jeppeman
Copy link
Contributor

Fixes #162

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     88.06%   88.06%           
  Complexity       43       43           
=========================================
  Files             1        1           
  Lines           176      176           
  Branches         24       24           
=========================================
  Hits            155      155           
  Misses           13       13           
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
...ktech/android/junit/jacoco/GenerationPlugin.groovy 88.06% <ø> (ø) 43 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5461b09...f24c747. Read the comment docs.

@vanniktech vanniktech requested a review from vRallev January 10, 2020 18:13
Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my side. Waiting for a review from @vRallev

@vanniktech vanniktech merged commit 0b2f3d6 into vanniktech:master Jan 13, 2020
@jeppeman
Copy link
Contributor Author

👍 Can we make a release with this fix?

@vanniktech
Copy link
Owner

Will do this weekend / next week!

@openkwaky
Copy link

Hello,
it would be very helpful to get a release soon.
I'm using 0.16.0-SNAPSHOT for the moment and feeling uncomfortable with it 😄
Thank you for the good work by the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android Gradle Plugin 3.5 breaks configuration
4 participants