add pom developer url support (#88)

vanniktech · Jan 25, 2020 · eb962d7 · eb962d7
1 parent fe49d77
commit eb962d7
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 8 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -19,3 +19,4 @@ POM_LICENCE_DIST=repo
 
 POM_DEVELOPER_ID=vanniktech
 POM_DEVELOPER_NAME=Niklas Baudy
+POM_DEVELOPER_URL=https://github.com/vanniktech/
diff --git a/src/integrationTest/fixtures/common/expected/test-artifact.pom b/src/integrationTest/fixtures/common/expected/test-artifact.pom
@@ -19,11 +19,12 @@
     <developer>
       <id>vanniktech</id>
       <name>Niklas Baudy</name>
+      <url>https://github.com/vanniktech/</url>
     </developer>
   </developers>
   <scm>
     <connection>scm:git:git://github.com/vanniktech/gradle-maven-publish-plugin.git</connection>
     <developerConnection>scm:git:ssh://git@github.com/vanniktech/gradle-maven-publish-plugin.git</developerConnection>
     <url>https://github.com/vanniktech/gradle-maven-publish-plugin/</url>
   </scm>
-</project>
+</project>
diff --git a/src/integrationTest/fixtures/common/gradle.properties b/src/integrationTest/fixtures/common/gradle.properties
@@ -15,6 +15,7 @@ POM_LICENCE_DIST=repo
 
 POM_DEVELOPER_ID=vanniktech
 POM_DEVELOPER_NAME=Niklas Baudy
+POM_DEVELOPER_URL=https://github.com/vanniktech/
 
 signing.keyId=B89C4055
 signing.password=test

diff --git a/src/integrationTest/fixtures/passing_android_project/expected/test-artifact.pom b/src/integrationTest/fixtures/passing_android_project/expected/test-artifact.pom
@@ -19,11 +19,12 @@
     <developer>
       <id>vanniktech</id>
       <name>Niklas Baudy</name>
+      <url>https://github.com/vanniktech/</url>
     </developer>
   </developers>
   <scm>
     <connection>scm:git:git://github.com/vanniktech/gradle-maven-publish-plugin.git</connection>
     <developerConnection>scm:git:ssh://git@github.com/vanniktech/gradle-maven-publish-plugin.git</developerConnection>
     <url>https://github.com/vanniktech/gradle-maven-publish-plugin/</url>
   </scm>
-</project>
+</project>
diff --git a/src/integrationTest/fixtures/passing_android_with_kotlin_project/expected/test-artifact.pom b/src/integrationTest/fixtures/passing_android_with_kotlin_project/expected/test-artifact.pom
@@ -19,6 +19,7 @@
     <developer>
       <id>vanniktech</id>
       <name>Niklas Baudy</name>
+      <url>https://github.com/vanniktech/</url>
     </developer>
   </developers>
   <scm>
@@ -34,4 +35,4 @@
       <scope>compile</scope>
     </dependency>
   </dependencies>
-</project>
+</project>
diff --git a/...egrationTest/fixtures/passing_java_library_with_groovy_project/expected/test-artifact.pom b/...egrationTest/fixtures/passing_java_library_with_groovy_project/expected/test-artifact.pom
@@ -19,6 +19,7 @@
     <developer>
       <id>vanniktech</id>
       <name>Niklas Baudy</name>
+      <url>https://github.com/vanniktech/</url>
     </developer>
   </developers>
   <scm>
@@ -34,4 +35,4 @@
       <scope>compile</scope>
     </dependency>
   </dependencies>
-</project>
+</project>
diff --git a/...egrationTest/fixtures/passing_java_library_with_kotlin_project/expected/test-artifact.pom b/...egrationTest/fixtures/passing_java_library_with_kotlin_project/expected/test-artifact.pom
@@ -18,6 +18,7 @@
     <developer>
       <id>vanniktech</id>
       <name>Niklas Baudy</name>
+      <url>https://github.com/vanniktech/</url>
     </developer>
   </developers>
   <scm>
@@ -33,4 +34,4 @@
       <scope>compile</scope>
     </dependency>
   </dependencies>
-</project>
+</project>
diff --git a/src/integrationTest/fixtures/passing_java_with_kotlin_project/expected/test-artifact.pom b/src/integrationTest/fixtures/passing_java_with_kotlin_project/expected/test-artifact.pom
@@ -18,6 +18,7 @@
     <developer>
       <id>vanniktech</id>
       <name>Niklas Baudy</name>
+      <url>https://github.com/vanniktech/</url>
     </developer>
   </developers>
   <scm>
@@ -33,4 +34,4 @@
       <scope>compile</scope>
     </dependency>
   </dependencies>
-</project>
+</project>
diff --git a/src/main/groovy/com/vanniktech/maven/publish/MavenPublishPlugin.groovy b/src/main/groovy/com/vanniktech/maven/publish/MavenPublishPlugin.groovy
@@ -187,6 +187,7 @@ class MavenPublishPlugin extends BaseMavenPublishPlugin {
         developer {
           id publishPom.developerId
           name publishPom.developerName
+          url publishPom.developerUrl
         }
       }
     }

diff --git a/src/main/kotlin/com/vanniktech/maven/publish/MavenPublishConfigurer.kt b/src/main/kotlin/com/vanniktech/maven/publish/MavenPublishConfigurer.kt
@@ -53,6 +53,7 @@ internal class MavenPublishConfigurer(private val project: Project) : Configurer
           developers.developer {
             it.id.set(publishPom.developerId)
             it.name.set(publishPom.developerName)
+            it.url.set(publishPom.developerUrl)
           }
         }
       }

diff --git a/src/main/kotlin/com/vanniktech/maven/publish/MavenPublishPom.kt b/src/main/kotlin/com/vanniktech/maven/publish/MavenPublishPom.kt
@@ -21,7 +21,8 @@ internal data class MavenPublishPom(
   val licenseDistribution: String?,
 
   val developerId: String?,
-  val developerName: String?
+  val developerName: String?,
+  val developerUrl: String?
 ) {
 
   internal companion object {
@@ -41,7 +42,8 @@ internal data class MavenPublishPom(
         findOptionalProperty(project, "POM_LICENCE_URL"),
         findOptionalProperty(project, "POM_LICENCE_DIST"),
         findOptionalProperty(project, "POM_DEVELOPER_ID"),
-        findOptionalProperty(project, "POM_DEVELOPER_NAME")
+        findOptionalProperty(project, "POM_DEVELOPER_NAME"),
+        findOptionalProperty(project, "POM_DEVELOPER_URL")
     )
 
     private fun findMandatoryProperty(project: Project, propertyName: String): String {