Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing optional properties may produce literal nulls in output #76

Closed
koral-- opened this issue Jan 6, 2020 · 1 comment · Fixed by #89
Closed

Missing optional properties may produce literal nulls in output #76

koral-- opened this issue Jan 6, 2020 · 1 comment · Fixed by #89

Comments

@koral--
Copy link

koral-- commented Jan 6, 2020

Coming from that issue: mikepenz/AboutLibraries#461 through another one square/okhttp#5683 it turns out that if POM_DESCRIPTION is not set (I haven't found that in okhttp 4.x sources) then string with content "null" is produced in POM instead of not adding anything at all. Okhttp uses this plugin: https://github.com/square/okhttp/blob/master/okhttp/build.gradle#L1

I haven't tried to reproduce this nor further investigate if issue is located here or maybe in underlying Gradle implementation since my original issue at AboutLibraries has gone. I filled this issue because maybe someone else will be interested in investigation.

@gabrielittner
Copy link
Collaborator

Thanks for the report. It's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants