Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't write null values to pom #89

Merged
merged 4 commits into from
Jan 25, 2020
Merged

don't write null values to pom #89

merged 4 commits into from
Jan 25, 2020

Conversation

gabrielittner
Copy link
Collaborator

closes #76

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #89 into master will decrease coverage by 0.31%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     58.33%   58.02%   -0.32%     
- Complexity       45       46       +1     
============================================
  Files             8        8              
  Lines           288      293       +5     
  Branches         34       35       +1     
============================================
+ Hits            168      170       +2     
- Misses           96       98       +2     
- Partials         24       25       +1
Impacted Files Coverage Δ Complexity Δ
...vanniktech/maven/publish/MavenPublishConfigurer.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/com/vanniktech/maven/publish/MavenPublishPom.kt 95% <100%> (+0.26%) 17 <2> (+1) ⬆️
...vanniktech/maven/publish/MavenPublishPlugin.groovy 63.71% <50%> (-1.15%) 8 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d3fde...49061fb. Read the comment docs.

@gabrielittner gabrielittner merged commit feaaa27 into master Jan 25, 2020
@gabrielittner gabrielittner deleted the pom-null-test branch January 25, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing optional properties may produce literal nulls in output
2 participants