-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial Kotlin Multiplatform support #105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
============================================
- Coverage 36.67% 35.44% -1.23%
+ Complexity 50 49 -1
============================================
Files 21 22 +1
Lines 409 426 +17
Branches 67 70 +3
============================================
+ Hits 150 151 +1
- Misses 231 246 +15
- Partials 28 29 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dope. Would @Egorand be willing to give it a try?
I forgot to mention that I've tested this with a local snapshot on SqlDelight. sqldelight/sqldelight@master...gabrielittner:publish-plugin |
Oh wow. That's even neater. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
@@ -7,6 +7,8 @@ internal interface Configurer { | |||
*/ | |||
fun configureTarget(target: MavenPublishTarget) | |||
|
|||
fun configureMultiplatformProject() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Multiplatform
-> KotlinMultiplatform
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense #112
This adds support to publish multiplatform projects to all configured targets and sets up the coordinates and pom according to our properties.
Also updated Dokka to 0.10.0 which adds experimental multiplatform support. Without that projects would have to configure some things manually to avoid all builds failing.
closes #57