Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial Kotlin Multiplatform support #105

Merged
merged 3 commits into from
Feb 1, 2020
Merged

initial Kotlin Multiplatform support #105

merged 3 commits into from
Feb 1, 2020

Conversation

gabrielittner
Copy link
Collaborator

@gabrielittner gabrielittner commented Feb 1, 2020

This adds support to publish multiplatform projects to all configured targets and sets up the coordinates and pom according to our properties.

Also updated Dokka to 0.10.0 which adds experimental multiplatform support. Without that projects would have to configure some things manually to avoid all builds failing.

closes #57

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #105 into master will decrease coverage by 1.22%.
The diff coverage is 4.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
- Coverage     36.67%   35.44%   -1.23%     
+ Complexity       50       49       -1     
============================================
  Files            21       22       +1     
  Lines           409      426      +17     
  Branches         67       70       +3     
============================================
+ Hits            150      151       +1     
- Misses          231      246      +15     
- Partials         28       29       +1
Impacted Files Coverage Δ Complexity Δ
...vanniktech/maven/publish/MavenPublishConfigurer.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../vanniktech/maven/publish/tasks/EmptySourcesJar.kt 0% <0%> (ø) 0 <0> (?)
...nniktech/maven/publish/UploadArchivesConfigurer.kt 85.29% <0%> (-2.59%) 10 <0> (ø)
...vanniktech/maven/publish/BaseMavenPublishPlugin.kt 61.36% <40%> (-3.64%) 5 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19bb3f8...fb997e6. Read the comment docs.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dope. Would @Egorand be willing to give it a try?

build.gradle Outdated Show resolved Hide resolved
@gabrielittner
Copy link
Collaborator Author

I forgot to mention that I've tested this with a local snapshot on SqlDelight. sqldelight/sqldelight@master...gabrielittner:publish-plugin
One thing that needs to happen for everything to work is updating Dokka in SqlDelight (my local snapshot was still using 0.9.x). Running the branch above with this pr would cause dokka to fail.

@gabrielittner gabrielittner merged commit eeb6550 into vanniktech:master Feb 1, 2020
@vanniktech
Copy link
Owner

Oh wow. That's even neater.

Copy link

@Egorand Egorand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@@ -7,6 +7,8 @@ internal interface Configurer {
*/
fun configureTarget(target: MavenPublishTarget)

fun configureMultiplatformProject()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Multiplatform -> KotlinMultiplatform?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support publishing of Kotlin Multiplatform projects
3 participants