fix plugin marker pom not containing name and description #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
============================================
- Coverage 33.93% 33.85% -0.08%
Complexity 51 51
============================================
Files 22 22
Lines 445 446 +1
Branches 73 73
============================================
Hits 151 151
- Misses 264 265 +1
Partials 30 30
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Feb 23, 2020
| @@ -148,6 +148,12 @@ internal class MavenPublishConfigurer( | |||
| if (it.name == "${plugin.name}PluginMarkerMaven") { | |||
| // keep the current group and artifact ids, they are based on the gradle plugin id | |||
| configurePom(it, groupId = it.groupId, artifactId = it.artifactId) | |||
| // workaround for https://github.com/gradle/gradle/issues/12259 | |||
| it.pom.withXml { pom -> | |||
| pom.asNode().appendNode("name", publishPom.name) | |||
There was a problem hiding this comment.
Is there something like replace or set? That way if Gradle were to fix their bug we won't be having two <name> tags?
There was a problem hiding this comment.
👍 I've added checks around these. Tested it manually by adding
it.pom.withXml { pom ->
pom.asNode().appendNode("name", "1")
pom.asNode().appendNode("description", "2")
}before which resulted in the tests failing because the pom contained 1 and 2.
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a workaround. Closes #117