Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy mode #135

Merged
merged 1 commit into from
May 15, 2020
Merged

remove legacy mode #135

merged 1 commit into from
May 15, 2020

Conversation

gabrielittner
Copy link
Collaborator

  • remove useLegacyMode and delete the old configuration
  • remove the groovy build configuration

Follow ups:

  • simplify the maven-publish setup (like applying the plugin immediately instead of in afterEvaluate)
  • I will create an issue to outline my general idea of where to go from here

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #135 into master will increase coverage by 9.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
+ Coverage     33.70%   43.25%   +9.54%     
  Complexity       52       52              
============================================
  Files            22       20       -2     
  Lines           448      363      -85     
  Branches         80       60      -20     
============================================
+ Hits            151      157       +6     
+ Misses          266      182      -84     
+ Partials         31       24       -7     
Impacted Files Coverage Δ Complexity Δ
...ktech/maven/publish/MavenPublishPluginExtension.kt 65.00% <ø> (-1.67%) 4.00 <0.00> (-1.00)
...com/vanniktech/maven/publish/MavenPublishPlugin.kt 63.63% <100.00%> (ø) 7.00 <1.00> (?)
...com/vanniktech/maven/publish/MavenPublishTarget.kt 90.00% <0.00%> (-10.00%) 7.00% <0.00%> (ø%)
...in/com/vanniktech/maven/publish/MavenPublishPom.kt 97.14% <0.00%> (-2.86%) 16.00% <0.00%> (-1.00%)
...vanniktech/maven/publish/MavenPublishConfigurer.kt 62.88% <0.00%> (+62.88%) 14.00% <0.00%> (+14.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f7020...0cf851f. Read the comment docs.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gabrielittner gabrielittner marked this pull request as ready for review May 15, 2020 15:01
@gabrielittner gabrielittner merged commit 338b27e into master May 15, 2020
@gabrielittner gabrielittner deleted the remove-legacy-mode branch May 15, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants