Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change how closeAndReleaseRepository is created to avoid ClassCastException #157

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

gabrielittner
Copy link
Collaborator

I'm not sure why the crash was happening, but this avoids it by avoiding the cast entirely. The task is now also created lazily. I've tested it locally on Kotlinpoet with an includeBuild.

Closes #156

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #157 into master will decrease coverage by 1.65%.
The diff coverage is 21.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #157      +/-   ##
============================================
- Coverage     45.35%   43.69%   -1.66%     
+ Complexity       52       50       -2     
============================================
  Files            20       20              
  Lines           366      373       +7     
  Branches         58       58              
============================================
- Hits            166      163       -3     
- Misses          174      184      +10     
  Partials         26       26              
Impacted Files Coverage Δ Complexity Δ
.../com/vanniktech/maven/publish/ProjectExtensions.kt 18.18% <0.00%> (-10.39%) 0.00 <0.00> (ø)
...nniktech/maven/publish/tasks/AndroidJavadocsJar.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../com/vanniktech/maven/publish/tasks/JavadocsJar.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../vanniktech/maven/publish/nexus/NexusConfigurer.kt 55.55% <42.85%> (-44.45%) 1.00 <0.00> (ø)
...ven/publish/nexus/CloseAndReleaseRepositoryTask.kt 0.00% <0.00%> (-15.39%) 0.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0117346...94d7907. Read the comment docs.

@gabrielittner gabrielittner merged commit e0217d9 into master Sep 4, 2020
@gabrielittner gabrielittner deleted the fix-close-and-release-task branch September 4, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants