improve when signing tasks run, consider all targets for signing

[gabrielittner]

• signing configuration isn't part of afterEvaluate anymore which makes manually overriding it easier
• required (= task fails when signing isn't set up on the local machine) only considers if the task is a snapshot
• signing will only be run when also running an Upload task (not during things like assemble)
• the previous point will now consider all targets, before only uploadArchives was considered
• added info level logs to make debugging issues easier

fixes #29

[gabrielittner]

One downside of the new onlyIf implementation is that you can't run signing explicitly. ./gradlew signArchives will skip the task because none of the upload tasks are in the task graph.

[codecov]

Codecov Report

Merging #30 into master will decrease coverage by 5.9%.
The diff coverage is 42.1%.

@@             Coverage Diff              @@
##             master      #30      +/-   ##
============================================
- Coverage        90%   84.09%   -5.91%     
- Complexity       13       15       +2     
============================================
  Files             3        3              
  Lines           120      132      +12     
  Branches         14       14              
============================================
+ Hits            108      111       +3     
- Misses            5       13       +8     
- Partials          7        8       +1

Impacted Files	Coverage Δ	Complexity Δ
...com/vanniktech/maven/publish/MavenPublishTarget.kt	70% <33.33%> (-15.72%)	5 <2> (+2)
...vanniktech/maven/publish/MavenPublishPlugin.groovy	87.61% <43.75%> (-6.14%)	6 <0> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b908e6...cb41397. Read the comment docs.

[vanniktech]

Are there tests for this given that the API is public?

[gabrielittner]

I'll add them. I wanted to make it internal, but Groovy didn't like that for some reason.

[vanniktech]

One downside of the new onlyIf implementation is that you can't run signing explicitly. ./gradlew signArchives will skip the task because none of the upload tasks are in the task graph.

Totally fine.

[codecov-io]

Codecov Report

Merging #30 into master will decrease coverage by 4.39%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##             master     #30     +/-   ##
==========================================
- Coverage        90%   85.6%   -4.4%     
- Complexity       13      16      +3     
==========================================
  Files             3       3             
  Lines           120     132     +12     
  Branches         14      14             
==========================================
+ Hits            108     113      +5     
- Misses            5      12      +7     
  Partials          7       7

Impacted Files	Coverage Δ	Complexity Δ
...com/vanniktech/maven/publish/MavenPublishTarget.kt	90% <100%> (+4.28%)	6 <3> (+3)	⬆️
...vanniktech/maven/publish/MavenPublishPlugin.groovy	87.61% <43.75%> (-6.14%)	6 <0> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b908e6...4d8bf93. Read the comment docs.

[gabrielittner]

Should be good now.