let integration tests run with maven publish, enable signing #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=========================================
Coverage 64.72% 64.72%
Complexity 45 45
=========================================
Files 8 8
Lines 275 275
Branches 22 22
=========================================
Hits 178 178
Misses 85 85
Partials 12 12Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run all existing tests also with
useMavenPublish = true. Since that mode does not support enabling/disabling signing on a target level (from a quick look supporting that is not possible since you only sign the publication not it's targets) this also enables signing for all integration tests in both modes and adds assertions thatascfiles are created.