Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly set repository credentials to null in tests #85

Merged
merged 2 commits into from
Jan 21, 2020
Merged

explicitly set repository credentials to null in tests #85

merged 2 commits into from
Jan 21, 2020

Conversation

gabrielittner
Copy link
Collaborator

@gabrielittner gabrielittner commented Jan 19, 2020

It failed because the tests picked up the publishing credentials from env vars which are not added to pull requests: Authentication scheme 'all'(Authentication) is not supported by protocol 'file'.

@gabrielittner gabrielittner changed the title Fix tests master explicitly set repository credentials to null in tests Jan 19, 2020
@gabrielittner gabrielittner marked this pull request as ready for review January 19, 2020 16:39
@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fcbfa39). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage          ?   64.13%           
  Complexity        ?       45           
=========================================
  Files             ?        8           
  Lines             ?      276           
  Branches          ?       22           
=========================================
  Hits              ?      177           
  Misses            ?       87           
  Partials          ?       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbfa39...8d37f8b. Read the comment docs.

@gabrielittner gabrielittner merged commit fe49d77 into vanniktech:master Jan 21, 2020
@gabrielittner gabrielittner deleted the fix-tests-master branch January 21, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants