Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send full range updates if old range overlaps new range #73

Open
wants to merge 2 commits into
base: live-elo
Choose a base branch
from

Conversation

owobred
Copy link
Collaborator

@owobred owobred commented Dec 20, 2024

Changes

The websocket proxy will now send smaller updates when changing from a smaller window to a larger one.

For example, moving from a window of 0..=5 -> 0..=7 would previously send all of 0..=7, whereas it only actually needs to send 5..=7 to fill the empty space.

|---|
|-----|
     ^^ only these would get sent

The following updates remain the same, this just means that much less gets sent with the current scrolling system.

Checklist

  • My code compiles
  • I have committed all the files needed to build the project (check if your file is found in .gitignore)
  • If I'm introducing a new step in the build process, I have documented / automated it
  • I have tested my changes (minimally with one Twitch VOD)

To-do list

  • Test that this works as expected, and I haven't made it accidently miss out sections in certain cases
  • Test that this doesn't cause issues with the frontend

@owobred owobred self-assigned this Dec 20, 2024
@owobred owobred marked this pull request as ready for review December 20, 2024 13:42
@owobred owobred requested a review from jameshi16 December 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant