Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mongodb connector #61

Merged
merged 5 commits into from
Sep 7, 2022
Merged

feat: add mongodb connector #61

merged 5 commits into from
Sep 7, 2022

Conversation

wenfengwang
Copy link
Contributor

@wenfengwang wenfengwang commented Aug 31, 2022 •
edited
Loading

Changes:

  1. add mongo-source
  2. add mongo-sink
  3. scaffolding event schema with protobuf
  4. add unified Dockerfiles for Go and Java connectors
  5. add templates for further connectors (not finished) (already merged in feat: add templates & third part of proto #58 )
  6. add the specification for how to create a new connector (not finished)

@wenfengwang
Copy link
Contributor Author

reopen #55

JieDing
JieDing reviewed Sep 7, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
connectors/mongodb-sink/internal/server.go Show resolved Hide resolved
wenfengwang and others added 3 commits September 7, 2022 14:23
@wenfengwang
Update CONTRIBUTING.md
eea2afd 
Co-authored-by: JieDing <jie.ding@linkall.com>
@wenfengwang
Update CONTRIBUTING.md
79cd21d 
Co-authored-by: JieDing <jie.ding@linkall.com>
@wenfengwang
Update CONTRIBUTING.md
303f9d8 
Co-authored-by: JieDing <jie.ding@linkall.com>
Michaelg22
Michaelg22 reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@Michaelg22 Michaelg22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme needs some updates see comments :)

connectors/mongodb-sink/README.md Outdated Show resolved Hide resolved
JieDing
JieDing approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@JieDing JieDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JieDing JieDing merged commit 7658472 into main Sep 7, 2022
@JieDing JieDing deleted the mongo-connector-cvt branch September 7, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelg22 Michaelg22 Michaelg22 left review comments

@JieDing JieDing JieDing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenfengwang @JieDing @Michaelg22