Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate DeepCell Tracking to TF2 #470

Merged
merged 5 commits into from
Jan 11, 2021
Merged

Migrate DeepCell Tracking to TF2 #470

merged 5 commits into from
Jan 11, 2021

Conversation

MekWarrior
Copy link
Collaborator

What

  • Change the tracking data generator and model to support batches as dictionaries rather than one array. Adapt the train model function to use tf.datasets based on the new data generator.

Why

  • The old tracking model, data generator, and train model function did not support TF2. These adaptations complete deepcell-tf's migration to the latest version of TensorFlow.

willgraf
willgraf reviewed Jan 11, 2021
View reviewed changes
deepcell/training.py Outdated Show resolved Hide resolved
willgraf
willgraf reviewed Jan 11, 2021
View reviewed changes
Copy link
Contributor

@willgraf willgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generator changes look good, but I'm hopeful we can clean up the training.py script a bit before merging.

@willgraf willgraf self-requested a review January 11, 2021 21:35
willgraf
willgraf approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@willgraf willgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving despite the reduced code coverage because:

  • There is an existing TODO for correctness tests
  • training.py is currently untested.

@willgraf willgraf merged commit d4ac3b0 into master Jan 11, 2021
@willgraf willgraf deleted the tf2_tracking branch January 11, 2021 21:43
@willgraf willgraf mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willgraf willgraf willgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MekWarrior @willgraf