Fix tracking model bug that pinned n_filters, encoder_dim and embedding_dim to 64 #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from having values other than 64
…l request is just about the tracking model's bug fix
msschwartz21
approved these changes
Jun 4, 2022
msschwartz21
reviewed
Jun 4, 2022
| @@ -53,7 +53,8 @@ | |||
| class Track(object): # pylint: disable=useless-object-inheritance | |||
|
|
|||
| def __init__(self, path=None, tracked_data=None, | |||
| appearance_dim=32, distance_threshold=64): | |||
| appearance_dim=32, distance_threshold=64, | |||
| **kwargs): | |||
There was a problem hiding this comment.
Why are kwargs being exposed here? Is this coming from the other PR to expose crop mode and norm?
There was a problem hiding this comment.
Yeah I think that's a hold over from the other PR.
msschwartz21
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why