Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Increase gallery thumbnail size #695

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Sep 14, 2023

What

  • Minor cosmetic adjustments to increase the size of the thumbnails for the gallery. These values seem like a good balance for the RTD theme.
  • Also fixes missing mesmer application thumbnail image

Why

  • Improve gallery examples

@rossbar rossbar added the documentation README and sphinx content label Sep 14, 2023
@rossbar
Copy link
Contributor Author

rossbar commented Sep 15, 2023

CI complaints notwithstanding, here's what the gallery looks like with these changes as compared to the current configuration. Nothing earth-shattering, but hopefully a visibility improvement.

@rossbar
Copy link
Contributor Author

rossbar commented Jan 17, 2024

Okay, I've rebased on top of the fixed CI, so the docs builds+previews should be 100% operational again.

This PR deals only with aesthetics, so I leave it to others to judge whether the increased thumbnail sizes are an improvement:

LMK what you think @msschwartz21 @elaubsch - if the default thumbnails are preferred I'm happy to just close this!

Copy link
Member

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better! Thank you for the upgrade!

@rossbar rossbar merged commit e6d7af8 into vanvalenlab:master Jan 18, 2024
14 checks passed
@rossbar rossbar deleted the doc/increase-thumbnail-size branch January 18, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation README and sphinx content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants