-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the package #122
Merged
Merged
Upgrade the package #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better to use logical properties for control the layout. Also, a different color scheme depending on the users default appearance.
As a target it becomes testable.
The javascript for the interactions needs to be declared in an other way, therefore it should be its own file, when it gets bundled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds some elements and attributes like for vectors or the shadow DOM. It also revamps the CSS.
Custom properties
Logical properties
I am in favor of the logical properties. I know they are hardly used or supported at the moment. But I think it will be better, when HTMLKit is out of beta. Also someone has to start using them. :-)
Appearance Mode
The appearance of components (light or dark) was previously triggered by the system preference. But sometimes you want to force a specific appearance despite it. By the change from the media query 'prefers-color-scheme' to a simple css class, it can be now forced for the whole webpage.
But also you can force it for an single component.
Minification
As the code and the complexity for the CSS and JS grows, I thought its time to write a minifier to reduce the size of the file on deployment. At the moment the minifier just removes whitespaces and comments.