Missing errorcodes #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wibe <pbwo@pm.me>
Signed-off-by: wibe <pbwo@pm.me>
Signed-off-by: wibe <pbwo@pm.me>
0xTim
requested changes
Mar 20, 2024
There was a problem hiding this comment.
I like this but it's a breaking change. I'm happy to roll it into a major release with the async/await changes but if we're going to do that we should remove the public enum altogether and replace it with static cases backed by an internal enum. See JWTError in JWTKit for reference
|
how does jwt kit map over imperial? could imperial be a thin wrapper and jwt-kit if it includes oauth tokens aswell? |
|
It doesn't at all. The two are completely unrelated. You could use a JWT once you've authenticated the user with Imperial but that's nothing to do with this library. The JWT link was only there as an example of how to get rid of a public enum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i replaced some manual errors with normalized counterparts