Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for accessing Secret Manager secret versions #33

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

owainhunt
Copy link

Adds support for hitting the projects.secrets.versions.access endpoint of the Secret Manager REST API. This is just one endpoint of a larger API, but is one of the most useful endpoints to hit from a server application.

@owainhunt
Copy link
Author

cc @Andrewangeta

@Andrewangeta
Copy link
Member

@owainhunt Looks good to me! @jordanebelanger did you wanna try to add the refreshing protection in so we could get all that plus this API out at once?

@owainhunt
Copy link
Author

Just added some more error types. @Andrewangeta any progress on getting this merged in?

@Andrewangeta
Copy link
Member

@owainhunt Sorry about getting this behind man 😭. I don't mind merging this in and then doing a separate release with improvements if you need this ASAP. Time is no where to be found but I will be on holiday starting next week and that should help give me time to catch up.

@owainhunt
Copy link
Author

@Andrewangeta not a problem 🙂 we've been using the fork internally, and I'm on holiday now anyway, so no great rush if there are other things you want to get in with this one.

SecretManager/Sources/SecretManagerClient.swift Outdated Show resolved Hide resolved
SecretManager/Sources/README.md Outdated Show resolved Hide resolved
SecretManager/Sources/README.md Outdated Show resolved Hide resolved
SecretManager/Sources/README.md Outdated Show resolved Hide resolved
@flopshot
Copy link

flopshot commented Jan 4, 2021

@owainhunt I tried your fork today and it works with my project perfectly.

@owainhunt
Copy link
Author

@Andrewangeta any chance of getting this merged in?

@flopshot
Copy link

@Andrewangeta any chance of getting this merged in?

I've been using this fork for a few months now. Still working as expected.

@Andrewangeta
Copy link
Member

Yea I've been behind and this for a while now and let's get this merged in now and we'll do more significant changes like I was planning later on when time permits.

@Andrewangeta Andrewangeta merged commit e59ab06 into vapor-community:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants