-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebuild the unit test suite for synse server #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmm. seems like the tests can be intermittent in CI. haven't seen that issue on my machine yet.. will dig into this. I suspect its because of the rapid setup/teardown of the test sanic server.. |
edaniszewski
added a commit
that referenced
this pull request
Mar 27, 2020
edaniszewski
added a commit
that referenced
this pull request
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebuilds the entire unit test suite for Synse Server, fixing up a lot of the odd/inconsistent/bad test patterns from before, simplifying things a bit, and vastly expanding the number of tests and coverage. There are two caveats to this test suite right now:
/readcache
endpoint are written, but they are all skipped. I have not been able to get the tests working with the existing testing tools. The issue seems to be around sanic's testing support around response streaming. I opened a discussion topic on their help board and will wait for a resolution there before determining what the next steps are.fixes #220