-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ConsoleKit into two functional targets #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation needs updating otherwise mainly LGTM
@@ -16,7 +16,6 @@ struct AsyncExample { | |||
try await console.run(group, input: input) | |||
} catch let error { | |||
console.error("\(error)") | |||
exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not exit(1)
anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'cause it had no meaningful effect, and exiting with a nonzero status is arguably a questionable behavior to provide as an example (especially when exit(1)
isn't a fully platform-agnostic or even necessarily correct means of doing so)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add to the other reviews
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 49.28% 48.61% -0.68%
==========================================
Files 45 44 -1
Lines 1901 1874 -27
==========================================
- Hits 937 911 -26
+ Misses 964 963 -1
|
…action, one for command handling, plus an umbrella for compatibility. Also update README, and docs images. Clean up several bits of code.
Co-authored-by: Mahdi Bahrami <github@mahdibm.com> Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
…sons learned from apple/swift-argument-parser#590, pretty much just for the hell of it. Deprecate `ConsoleErrror`.
These changes are now available in 4.12.0 |
ConsoleKit has been split into two separate targets:
ConsoleKitTerminal
contains the logic for interacting with a console (I/O, color support, other ANSI commands, etc.).ConsoleKitCommands
contains the functionality for handling argument parsing, which is now soft-deprecated in favor ofswift-argument-parser
when possible.The existing
ConsoleKit
target is now an umbrella import, similar to the function of theNIO
target inswift-nio
; existing code should be unaffected.Several additional minor cleanups were also made in the process of this split.