Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise async commands support #196

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Revise async commands support #196

merged 4 commits into from
Dec 6, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Dec 6, 2023

These changes are now available in 4.14.0

Changes:

  • Deprecates unnecessary API
  • Corrects the sync Command adapter methods
  • Cleans up some concurrency warnings

@gwynne gwynne added the semver-minor When merged, a new minor version release will be generated label Dec 6, 2023
@gwynne gwynne requested a review from 0xTim December 6, 2023 11:51
@codecov-commenter
Copy link

Codecov Report

Merging #196 (104578c) into main (18262d2) will increase coverage by 0.04%.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   48.25%   48.30%   +0.04%     
==========================================
  Files          44       45       +1     
  Lines        1892     1884       -8     
==========================================
- Hits          913      910       -3     
+ Misses        979      974       -5     
Files Coverage Δ
...s/ConsoleKitCommands/Async/AsyncCommandGroup.swift 90.56% <ø> (+11.87%) ⬆️
...onsoleKitTerminal/Activity/ActivityIndicator.swift 68.00% <ø> (ø)
...urces/ConsoleKitTerminal/Output/Console+Wait.swift 100.00% <100.00%> (ø)
Sources/ConsoleKitTerminal/Terminal/Terminal.swift 26.59% <ø> (ø)
.../ConsoleKitTerminal/Utilities/LoggerFragment.swift 80.30% <ø> (ø)
Sources/ConsoleKitCommands/Base/CommandGroup.swift 87.27% <50.00%> (+2.78%) ⬆️
Sources/ConsoleKitCommands/Base/AnyCommand.swift 0.00% <0.00%> (ø)
...tCommands/Deprecated/MergedAsyncCommandGroup.swift 0.00% <0.00%> (ø)
Sources/ConsoleKitTerminal/Terminal/ANSI.swift 83.87% <36.36%> (-3.77%) ⬇️

@gwynne gwynne merged commit a7dd700 into main Dec 6, 2023
13 checks passed
@gwynne gwynne deleted the revise-async-commands branch December 6, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor When merged, a new minor version release will be generated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants