Make siblings relation properties public #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner0101
approved these changes
May 20, 2020
tanner0101
added a commit
that referenced
this pull request
May 29, 2020
* Uniform field paths (#268) * unify field path structure for all drivers * cleanup files * rm dead code * nested group option * protocol cleanup + timestamp updates * updates * add Database.inTransaction (#192) * optional field updates * transaction + optional updates * add batch delete, fixes #114 * add constraint names, fixes #118 * support arbitrary join ordering, fixes #128 * add nil update tests, fixes #149 * add EnumBuilder.read(), fixes #194 * support @OptionalParent eager load, fixes #208 * test alias nesting, fixes #223 * parent optional * Fix dummy db placeholder (#200) * Add tests for placeholder for dummy database * Fix placeholder position Placeholder position should start at 1, not 2. No need to add 1 to position. * Rename variable to result * crud updates * clear method and middleware in batch creation (#220) Co-authored-by: Tanner <tannernelson@gmail.com> * merge conflicts * todo * batch delete middleware * Add entire models to the test database output. (#265) Co-authored-by: Tanner <tannernelson@gmail.com> * readble coding errors, fixes #231 * add decode test * add alter table constraints, fixes #235 * skip constraint test sqlite * fix @enum and @OptionalEnum decode, fixes #249 * add fluent sql sort overloads, fixes #266 * optional field batch create test, fixes #272 * add join partial select, fixes #274 * remove XCTUnwrap usages, fixes #278 * checkout postgres fluent gm branch * fix unit tests * setup dual dbs * retest * Make siblings relation properties public (#275) * add filter to partial select, fixes #274 * fix @OptionalParent.get when nil * add test for set to nil, fixes #284 * doc blocks * updat license year * use sqlite gm branch * package update * mysql updates * fix workflows * fluent branch * update mongo * rm nested Co-authored-by: Jean-Charles Campagne <jc.campagne@gmail.com> Co-authored-by: Mads Odgaard <mads@madsodgaard.com> Co-authored-by: Mathew Polzin <matt.polzin@gmail.com> Co-authored-by: Florian Friedrich <ffried@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making these properties public allows better extensibility.
In my case I need to use these properties to make manual joins. I'd otherwise have to make my model provide these keys manually, instead of using the existing siblings relation.