Add @Timestamp(key: "...", on: .none) functionality #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d manually and never overwritten by Fluent, but can still leverage the full power of TimestampFormats. It's a bit sad that this requires only one very trivial line of code in implementation but it takes 15 times that to have even very simple tests for it.
calebkleveter
approved these changes
Jun 19, 2020
MrLotU
approved these changes
Jun 19, 2020
|
I concur with @0xTim's concern; waiting on @tanner0101 to review. |
|
These changes are now available in 1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new case
.nonetoTimestampTrigger(#336).Using
TimestampTrigger.noneon a@Timestampproperty makes it act like a normal@OptionalField, so that Fluent never updates the timestamp automatically. Such properties retain the ability to take advantage ofTimestampFormats for explicitly defining the format of the timestamp value in the database.Note: Technically, since this adds an
enumcase, it would be asemver-majorchange, breaking source compatibility for anyone switching over theTimestampTriggertype. However, the expectation is doing this would be very rare.