Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional string contains operator #349

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Fix optional string contains operator #349

merged 3 commits into from
Jul 14, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Jul 14, 2020 •
edited
Loading

Fixes SQL conversion for the ~~ operator when used with optional fields (fixes #329).

@tanner0101 tanner0101 added the bug Something isn't working label Jul 14, 2020
@tanner0101 tanner0101 added the semver-minor Contains new APIs label Jul 14, 2020
@tanner0101 tanner0101 changed the title Fix optional string contains operator test Fix optional string contains operator Jul 14, 2020
@tanner0101 tanner0101 added semver-patch Internal changes only and removed semver-minor Contains new APIs labels Jul 14, 2020
@tanner0101 tanner0101 marked this pull request as ready for review July 14, 2020 17:25
@tanner0101 tanner0101 merged commit 9e618f6 into master Jul 14, 2020
@tanner0101 tanner0101 deleted the tn-string-contains-test branch July 14, 2020 17:25
@tanner0101
Copy link
Member Author

These changes are now available in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contains in Queries does not work with optionals.
1 participant
@tanner0101