Add ability to control transactions #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 43.48% 46.70% +3.21%
==========================================
Files 109 98 -11
Lines 6057 5548 -509
==========================================
- Hits 2634 2591 -43
+ Misses 3423 2957 -466
Flags with carried forward coverage won't be shown. Click here to find out more. |
gwynne
requested changes
Jun 30, 2022
Member
gwynne
left a comment
gwynne
left a comment
There was a problem hiding this comment.
LGTM, but can we add a documentation comment on the protocol itself warning about the caveats of using it?
Member
Author
|
Yes adding docs would actually be useful 🤦 |
gwynne
approved these changes
Jun 30, 2022
Member
gwynne
left a comment
gwynne
left a comment
There was a problem hiding this comment.
Couple of grammar and style nits, but otherwise LGTM
Co-authored-by: Gwynne Raskind <gwynne@vapor.codes>
|
These changes are now available in 1.31.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to control starting, committing and rolling back transactions outside of the main Fluent API. This could be used for setting up tests or when you need more control over a transaction.
Introduces a new
TransactionControlDatabaseprotocol to implement, that conforms toDatabase