Improved error reporting via DatabaseError
#203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdmcd
approved these changes
Dec 13, 2021
…ow correctly respect `MySQLError.invalidSyntax` and `MySQLError.closed`. A unit tests for these behaviors is included. Also avoids double-running the FluentBenchmark tests and adds the missing `testSQL()` benchmark test.
gwynne
force-pushed
the
correct-databaseerror-support
branch
from
eaa0c23 to
adaa851
Compare
|
Overriding spurious test failures to merge, but worth noting the timeout issue seems to be happening consistently with Xcode latest on macOS, bears looking into. |
|
These changes are now available in 4.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseError'sisSyntaxErrorandisConnectionClosedproperties now correctly respectMySQLError.invalidSyntaxandMySQLError.closederrors. A unit tests for these behaviors is included.Also avoids double-running the FluentBenchmark tests (same change as fluent-sqlite-driver#75).