Clean up row decoding #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clean up the corresponding API at this layer to call through instead of half-reimplementing (incorrectly) the same logic.
gwynne
added
enhancement
calebkleveter
approved these changes
Mar 18, 2022
0xTim
approved these changes
Mar 18, 2022
…t, use new checkout action
|
These changes are now available in 2.2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating logic implemented by
postgres-kitfor row decoding - and incorrectly, at that - we now always call through to that logic. Despite the additional indirection through theSQLRowexistential, this should yield a minor improvement in performance, as we perform fewer unnecessary checks and retain fewer copies of data.Note: Depends on vapor/postgres-kit#221 to receive the full benefit of these changes.