Warn about deprecation of old config methods instead of breaking existing code #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y working code using the old postgres configuration methods, while setting it up so the compiler correctly defaults to the new ones in ambiguous cases.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
===========================================
- Coverage 76.55% 61.49% -15.06%
===========================================
Files 7 8 +1
Lines 354 348 -6
===========================================
- Hits 271 214 -57
- Misses 83 134 +51
|
MahdiBM
approved these changes
May 11, 2023
| @@ -0,0 +1,18 @@ | |||
| API breakage: func DatabaseConfigurationFactory.postgres(configuration:maxConnectionsPerEventLoop:connectionPoolTimeout:encodingContext:decodingContext:sqlLogLevel:) has removed default argument from parameter 3 | |||
There was a problem hiding this comment.
Shouldn't this file be passed to the api-breakage CI using the --breakage-allowlist-path flag (or i see there is an option for it in the reusable CI) ?
There was a problem hiding this comment.
Or at second glance, i think you've made the re-useable CI default to this path, so this should be no issue.
There was a problem hiding this comment.
The reusable breakage check option looks for a file named for the branch being checked
|
These changes are now available in 2.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously working code which uses the now-deprecated
PostgresConfigurationtype with the.postgresfactory methods (rather than its replacement,SQLPostgresConfiguration) while specifying neither a data encoder or decoder was throwing compiler errors. Such code now issues the intended deprecation warning instead, while continuing to work as before.Fixes #211