Apply updates for improved interop with SQLKit #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 37.86% 38.84% +0.97%
==========================================
Files 13 13
Lines 750 865 +115
==========================================
+ Hits 284 336 +52
- Misses 466 529 +63
|
gwynne
force-pushed
the
update-alongside-sqlkit
branch
2 times, most recently
from
25f9c35
to
77ebe4d
Compare
gwynne
force-pushed
the
update-alongside-sqlkit
branch
from
77ebe4d
to
351468b
Compare
MahdiBM
approved these changes
Mar 24, 2024
MahdiBM
approved these changes
Mar 24, 2024
0xTim
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Do we actually have strict concurrency warnings without this manifest? I'm confused as to why we don't need this anymore, or was it because the flags weren't recognised in 5.7 but are in 5.8?
There was a problem hiding this comment.
Correct - the upcoming/experimental feature flag support was first available in SwiftPM as of 5.8; as of that version being the minimum, we don't need a separate manifest anymore unless we're using 5.9-only manifest features like macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 2.13.0
These changes bump the minimum Swift version to 5.8 and prepare PostgresKit for SQLKit's overhaul PR. The SQLKit changes are NOT required by this update.