Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new class (internal for the time being)
JobsWorker
encapsulates the complexRepeatedTask
logic.JobsCommand
gets a simplified responsibility of creating and runningn
JobsWorker
s. TheJobsCommand
is also responsible for shutting them down when requested from the command line.The files have been re-arranged slightly for better organization.
Fixes #27
QueueService
andQueueName
were renamed toJobsService
andJobsQueue
respectively.Fixes #29
I went a bit of a different route than described in the issue, but I think it's better. With this PR, you can configure Jobs with just a few lines of code:
Instead of relying on extensions to
JobsConfiguration
, this PR assumes thatRedisProvider
will exposeRedisClient
as a ready-to-use service.This makes
RedisClient
the only dependency thatJobsRedisDriver
has onRedisKit
.Fixes #26
JobsConfiguration
has had a few extra properties added to simplify configuration