Support Async Lifecycles #214
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 55.58% 52.88% -2.71%
==========================================
Files 11 11
Lines 412 399 -13
==========================================
- Hits 229 211 -18
- Misses 183 188 +5
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
.github/workflows/test.yml
Outdated
| gh-codeql: | ||
| if: ${{ !(github.event.pull_request.draft || false) }} | ||
| runs-on: ubuntu-latest | ||
| permissions: { actions: write, contents: read, security-events: write } | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - name: Install latest Swift toolchain | ||
| uses: vapor/swiftly-action@v0.1 | ||
| with: { toolchain: latest } | ||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
| - name: Fix Git configuration | ||
| run: 'git config --global --add safe.directory "${GITHUB_WORKSPACE}"' | ||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v3 | ||
| with: { languages: swift } | ||
| - name: Perform build | ||
| run: swift build | ||
| - name: Run CodeQL analyze | ||
| uses: github/codeql-action/analyze@v3 |
There was a problem hiding this comment.
CodeQL's still broken, pull this back out
These changes are now available in 4.11.0
Support Vapor's async
LifecycleHandlerfunctions. This allows users to avoid calling.wait()when shutting down their Vapor apps, which can cause issues, for example, with trying to install a new concurrency executor.This also updates the supported Swift version to 5.8