-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the use of unions in subqueries #178
Conversation
… to bad design choices in the original union support (my bad), this turns out to be mildly annoying to actually use and extremely painful to follow in the actual implementation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 98 +1
Lines 2551 2565 +14
=========================================
+ Hits 2551 2565 +14
|
API breakage notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're sure about the API breakage.
I am, actually 🙂. Look at the definition of |
These changes are now available in 3.30.0
Adds support for the use of
UNION
queries within subqueries. Unfortunately, thanks to iffy design choices on my part in the originalSQLUnion
implementation, the usage is slightly awkward. Example usage:This generates the following query:
Unfortunately, it is not possible to chain
.union()
when usingSQLSubquery.select(_:)
; the call chain must start withSQLSubquery.union(_:)
.