Update ktor to 3.0.0 #614
Merged
Update ktor to 3.0.0 #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitspittle
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Thanks for being on top of this!
Your approach to the keepalive delay is elegant code. When I was thinking of how to solve the issue when you first mentioned it, I assumed you would have used some sort of accumulating elapsed time value, because for some reason I didn't realize that structured concurrency was the perfect choice to use here. Probably my own neural net is trained too much on old, imperative, ugly ugly code :) Thanks for helping me see a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.