Update node_test.go with TestStaticNodeMatchRoute test case #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update node_test.go with TestStaticNodeMatchRoute test case and fix typo in test case.
vardius
reviewed
Aug 26, 2024
Comment on lines
-21
to
+34
| t.Fatalf("Expecting: *mux.staticNode. Wrong node type: %T\n", node) | ||
| t.Fatalf("Expecting: *mux.regexpNode. Wrong node type: %T\n", node) | ||
| case *wildcardNode: | ||
| t.Fatalf("Expecting: *mux.staticNode. Wrong node type: %T\n", node) | ||
| t.Fatalf("Expecting: *mux.regexpNode. Wrong node type: %T\n", node) | ||
| } | ||
|
|
||
| node = NewNode("{lang}", 0) | ||
|
|
||
| switch node := node.(type) { | ||
| case *staticNode: | ||
| t.Fatalf("Expecting: *mux.staticNode. Wrong node type: %T\n", node) | ||
| t.Fatalf("Expecting: *mux.wildcardNode. Wrong node type: %T\n", node) | ||
| case *regexpNode: | ||
| t.Fatalf("Expecting: *mux.staticNode. Wrong node type: %T\n", node) | ||
| t.Fatalf("Expecting: *mux.wildcardNode. Wrong node type: %T\n", node) |
There was a problem hiding this comment.
The error message is incorrect. The expected value should be wildcard,but it incorrectly states that the expected value is static. This issue is also present in the other error messages.
vardius
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vardius
this pr updates node_test.go with
TestStaticNodeMatchRoutetest case and fix typo in test case.