error msg fix #57
Merged
error msg fix #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is by design. If you go to Forms and try to add window.Materialize.toast(err.message, 4000); |
|
Displaying the error in separate element seems to work fine. |
|
Typically the built in error message would be smaller text and display right below the input line as pictured here: For some reason we have much larger text and there more space below the field:
The conflict is coming from somewhere in the css, but adding a separate < p > like you did works fine. |
jhowardjr
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Input field doesn't show errors anymore #44 - Good news: Error msg now shows. Bad news: text runs over where we display the results. I tried to target the are with no success, may be something we just let go on the edge case.
CSS issues: Card was getting cut off at bottom