added clear button #59
Conversation
src/components/FuncCard.js
Outdated
| @@ -21,6 +21,7 @@ class FuncCard extends Component { | |||
| this.handleToggleCode = this.handleToggleCode.bind(this); | |||
| this.handleParamsChange = this.handleParamsChange.bind(this); | |||
| this.handleRunCode = this.handleRunCode.bind(this); | |||
| this.handleClearCode = this.handleClearCode.bind(this); | |||
There was a problem hiding this comment.
Maybe handleClearParams instead of handleClearCode?
src/components/FuncCard.js
Outdated
| <Highlight lang="js" value={callCode} /> | ||
|
|
||
| <div className="results-div"> | ||
| <Button floating className='grey darken-3 small-btn' waves='light' icon='clear' onClick={this.handleClearCode}>Clear</Button> |
There was a problem hiding this comment.
Disabling the button when there are no params might be good.
disabled={params.length === 0}There was a problem hiding this comment.
I like that - and if there is not a value in result
|
I just realized that the text ofverflows button.
|
|
Yea it didn't look good adjacent to the params bar so that's why I put some opacity. Mentioned previously that we can move button wherever. I don't have any strong feels about where it lives. |
|
#60 - I bet this will fix the mobile issue: there was an option to render as "children" in the docs. |
| <Carousel> | ||
| {funcCards} | ||
| </Carousel> | ||
| <Carousel children={funcCards} /> |
There was a problem hiding this comment.
This doesn't change anything 😞 It doesn't matter how you set the children property, it will end up as props.children in Carousel component. The final result is the same.
There was a problem hiding this comment.
It doesn't work even if I replace everything in App with example code from https://react-materialize.github.io/#/carousel.
#50
Clear button styled and working. We can decide to move it wherever or leave it, but wanted to get this out while I had the chance. I also extended the width of the results component to try to squeeze a little extra room for text.